feat: Add Kernel management panel on extension popup#207
Merged
Conversation
sirtimid
force-pushed
the
sirtimid/kernel-devtools-panel
branch
2 times, most recently
from
698daa2 to
c022bd8
Compare
sirtimid
changed the title
sirtimid
changed the title
sirtimid
changed the title
sirtimid
force-pushed
the
sirtimid/kernel-devtools-panel
branch
2 times, most recently
from
17e0a7c to
27cfc88
Compare
sirtimid
force-pushed
the
sirtimid/kernel-devtools-panel
branch
from
3b617e6 to
745c10f
Compare
sirtimid
commented
Nov 11, 2024
sirtimid
commented
Nov 19, 2024
rekmarks
requested changes
Nov 19, 2024
Member
rekmarks
left a comment
rekmarks
left a comment
There was a problem hiding this comment.
Nice!
In addition to inline comments, passing an invalid vat id to "Launch Vat" in the popup appears to break the entire extension. Handling that error or preventing it via input validation would be good. The broken state is very broken.
sirtimid
force-pushed
the
sirtimid/kernel-devtools-panel
branch
from
d4f71cd to
524ff55
Compare
sirtimid
force-pushed
the
sirtimid/kernel-devtools-panel
branch
from
1689e7e to
93cec35
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #183 #216
This PR introduces a simple Kernel management panel within the extension popup, allowing users to initialize, restart, and shut down vats, as well as view the current status of the kernel and send messages.
For reviewers
There is now a new entry point popup.ts you can start from there to review the files in
panelfolder. For the other files start from theoffscreen.tsentry point.Screenshots
Screen.Recording.2024-11-06.at.18.19.00.mov